taxClassId are not saved with the rest of the product












0















I'm trying to update some attributes of my product by a cron to avoid common mistakes. The code causing me trouble is executed in a loop:



foreach ($storesIds as $storeId) {
$this->storeEmulation->startEnvironmentEmulation($storeId);
$fixed = $this->doExecute($storeId);
$this->storeEmulation->stopEnvironmentEmulation();
}


The "doExecute method" code is simplified here, tests are done before to avoid to save a product for nothing, here is how I'm saving a product:



$searchCriteria = $this->searchCriteriaBuilder->create();
$products = $this->productRepository->getList($searchCriteria)->getItems();

// [...]

foreach ($products as $product) {

// [...]

$fixes = ['visibility' => ['from' => $product->getVisibility(), 'to' => $expectedVisibility]];
$product->setStatus($expectedVisibility);

$fixes = ['taxClassId' => ['from' => $product->getTaxClassId(), 'to' => $expectedTaxClassId]];
$product->setTaxClassId($expectedTaxClassId);

try {
$this->productRepository->save($product);
$this->logger->notice('A product was fixed', [
'sku' => $product->getSku(),
'storeId' => $store->getId(),
'fixes' => $fixes
]);
} catch (Exception $e) {
$this->logger->error('A product can't be fixed', [
'sku' => $product->getSku(),
'storeId' => $store->getId(),
'fixes' => $fixes
]);
}
}


I can see in the logs that on the first fetch the visibility is fixed. But the taxClassId is not changing:



[2019-03-15 22:49:57] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]} 
[2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"visibility":{"from":"2","to":1}},{"taxClassId":{"from":"8","to":"2"}}]}
[2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}

[2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]}
[2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}
[2019-03-15 22:50:28] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}


Any idea where am I wrong?



Thanks for your help!










share|improve this question







New contributor




JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

























    0















    I'm trying to update some attributes of my product by a cron to avoid common mistakes. The code causing me trouble is executed in a loop:



    foreach ($storesIds as $storeId) {
    $this->storeEmulation->startEnvironmentEmulation($storeId);
    $fixed = $this->doExecute($storeId);
    $this->storeEmulation->stopEnvironmentEmulation();
    }


    The "doExecute method" code is simplified here, tests are done before to avoid to save a product for nothing, here is how I'm saving a product:



    $searchCriteria = $this->searchCriteriaBuilder->create();
    $products = $this->productRepository->getList($searchCriteria)->getItems();

    // [...]

    foreach ($products as $product) {

    // [...]

    $fixes = ['visibility' => ['from' => $product->getVisibility(), 'to' => $expectedVisibility]];
    $product->setStatus($expectedVisibility);

    $fixes = ['taxClassId' => ['from' => $product->getTaxClassId(), 'to' => $expectedTaxClassId]];
    $product->setTaxClassId($expectedTaxClassId);

    try {
    $this->productRepository->save($product);
    $this->logger->notice('A product was fixed', [
    'sku' => $product->getSku(),
    'storeId' => $store->getId(),
    'fixes' => $fixes
    ]);
    } catch (Exception $e) {
    $this->logger->error('A product can't be fixed', [
    'sku' => $product->getSku(),
    'storeId' => $store->getId(),
    'fixes' => $fixes
    ]);
    }
    }


    I can see in the logs that on the first fetch the visibility is fixed. But the taxClassId is not changing:



    [2019-03-15 22:49:57] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]} 
    [2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"visibility":{"from":"2","to":1}},{"taxClassId":{"from":"8","to":"2"}}]}
    [2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}

    [2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]}
    [2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}
    [2019-03-15 22:50:28] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}


    Any idea where am I wrong?



    Thanks for your help!










    share|improve this question







    New contributor




    JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.























      0












      0








      0








      I'm trying to update some attributes of my product by a cron to avoid common mistakes. The code causing me trouble is executed in a loop:



      foreach ($storesIds as $storeId) {
      $this->storeEmulation->startEnvironmentEmulation($storeId);
      $fixed = $this->doExecute($storeId);
      $this->storeEmulation->stopEnvironmentEmulation();
      }


      The "doExecute method" code is simplified here, tests are done before to avoid to save a product for nothing, here is how I'm saving a product:



      $searchCriteria = $this->searchCriteriaBuilder->create();
      $products = $this->productRepository->getList($searchCriteria)->getItems();

      // [...]

      foreach ($products as $product) {

      // [...]

      $fixes = ['visibility' => ['from' => $product->getVisibility(), 'to' => $expectedVisibility]];
      $product->setStatus($expectedVisibility);

      $fixes = ['taxClassId' => ['from' => $product->getTaxClassId(), 'to' => $expectedTaxClassId]];
      $product->setTaxClassId($expectedTaxClassId);

      try {
      $this->productRepository->save($product);
      $this->logger->notice('A product was fixed', [
      'sku' => $product->getSku(),
      'storeId' => $store->getId(),
      'fixes' => $fixes
      ]);
      } catch (Exception $e) {
      $this->logger->error('A product can't be fixed', [
      'sku' => $product->getSku(),
      'storeId' => $store->getId(),
      'fixes' => $fixes
      ]);
      }
      }


      I can see in the logs that on the first fetch the visibility is fixed. But the taxClassId is not changing:



      [2019-03-15 22:49:57] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]} 
      [2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"visibility":{"from":"2","to":1}},{"taxClassId":{"from":"8","to":"2"}}]}
      [2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}

      [2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]}
      [2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}
      [2019-03-15 22:50:28] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}


      Any idea where am I wrong?



      Thanks for your help!










      share|improve this question







      New contributor




      JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.












      I'm trying to update some attributes of my product by a cron to avoid common mistakes. The code causing me trouble is executed in a loop:



      foreach ($storesIds as $storeId) {
      $this->storeEmulation->startEnvironmentEmulation($storeId);
      $fixed = $this->doExecute($storeId);
      $this->storeEmulation->stopEnvironmentEmulation();
      }


      The "doExecute method" code is simplified here, tests are done before to avoid to save a product for nothing, here is how I'm saving a product:



      $searchCriteria = $this->searchCriteriaBuilder->create();
      $products = $this->productRepository->getList($searchCriteria)->getItems();

      // [...]

      foreach ($products as $product) {

      // [...]

      $fixes = ['visibility' => ['from' => $product->getVisibility(), 'to' => $expectedVisibility]];
      $product->setStatus($expectedVisibility);

      $fixes = ['taxClassId' => ['from' => $product->getTaxClassId(), 'to' => $expectedTaxClassId]];
      $product->setTaxClassId($expectedTaxClassId);

      try {
      $this->productRepository->save($product);
      $this->logger->notice('A product was fixed', [
      'sku' => $product->getSku(),
      'storeId' => $store->getId(),
      'fixes' => $fixes
      ]);
      } catch (Exception $e) {
      $this->logger->error('A product can't be fixed', [
      'sku' => $product->getSku(),
      'storeId' => $store->getId(),
      'fixes' => $fixes
      ]);
      }
      }


      I can see in the logs that on the first fetch the visibility is fixed. But the taxClassId is not changing:



      [2019-03-15 22:49:57] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]} 
      [2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"visibility":{"from":"2","to":1}},{"taxClassId":{"from":"8","to":"2"}}]}
      [2019-03-15 22:49:58] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}

      [2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"107","storeId":"8","fixes":[{"taxClassId":{"from":"0","to":"2"}}]}
      [2019-03-15 22:50:27] FixerLogger.NOTICE: A product was fixed {"sku":"018-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}
      [2019-03-15 22:50:28] FixerLogger.NOTICE: A product was fixed {"sku":"109-K","storeId":"8","fixes":[{"taxClassId":{"from":"8","to":"2"}}]}


      Any idea where am I wrong?



      Thanks for your help!







      products cron repository taxes environment-emulation






      share|improve this question







      New contributor




      JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 14 mins ago









      JeremyCJeremyC

      12




      12




      New contributor




      JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      JeremyC is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer








          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "479"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          JeremyC is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f266147%2ftaxclassid-are-not-saved-with-the-rest-of-the-product%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          JeremyC is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          JeremyC is a new contributor. Be nice, and check out our Code of Conduct.













          JeremyC is a new contributor. Be nice, and check out our Code of Conduct.












          JeremyC is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Magento Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f266147%2ftaxclassid-are-not-saved-with-the-rest-of-the-product%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Alcázar de San Juan

          Griza ansero

          Heinkel He 51