Mass delete action in one step not in loop magento 2
I have custom module with mass delete action feature. how to do mass delete action in one step without loop. Because i got WARNING | Model LSD method delete() detected in loop when i check my module in MEQP 2.
Below is the code used in my module
foreach ($collection as $block)
{
$block->delete();
}
After searching the mass action in the MAGE2 core file they too use the same method.
i refered the following path file is vendor/magento/module-cms/Controller/Adminhtml/Block/MassDelete.php
from line no 51 to 53
foreach ($collection as $page)
{
$page->delete();
}
i appreciate any one help on this.
magento2
asked Jun 22 '17 at 14:02
JjoJjo
835214
bumped to the homepage by Community♦ 2 mins ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
add a comment |
I have custom module with mass delete action feature. how to do mass delete action in one step without loop. Because i got WARNING | Model LSD method delete() detected in loop when i check my module in MEQP 2.
Below is the code used in my module
foreach ($collection as $block)
{
$block->delete();
}
After searching the mass action in the MAGE2 core file they too use the same method.
i refered the following path file is vendor/magento/module-cms/Controller/Adminhtml/Block/MassDelete.php
from line no 51 to 53
foreach ($collection as $page)
{
$page->delete();
}
i appreciate any one help on this.
magento2
asked Jun 22 '17 at 14:02
JjoJjo
835214
bumped to the homepage by Community♦ 2 mins ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
instead of iterating and deleting on object, use custom My Sql query to delete multiple row with where cause.
– Minesh Patel
Jun 29 '17 at 10:48
delete on object is only useful when you want to perform other operation before deleting it.
– Minesh Patel
Jun 29 '17 at 10:51
@Jjo did you find an answer to this? Thanks
– Tom Burman
Aug 2 '17 at 6:23
add a comment |
I have custom module with mass delete action feature. how to do mass delete action in one step without loop. Because i got WARNING | Model LSD method delete() detected in loop when i check my module in MEQP 2.
Below is the code used in my module
foreach ($collection as $block)
{
$block->delete();
}
After searching the mass action in the MAGE2 core file they too use the same method.
i refered the following path file is vendor/magento/module-cms/Controller/Adminhtml/Block/MassDelete.php
from line no 51 to 53
foreach ($collection as $page)
{
$page->delete();
}
i appreciate any one help on this.
magento2
asked Jun 22 '17 at 14:02
JjoJjo
835214
I have custom module with mass delete action feature. how to do mass delete action in one step without loop. Because i got WARNING | Model LSD method delete() detected in loop when i check my module in MEQP 2.
Below is the code used in my module
foreach ($collection as $block)
{
$block->delete();
}
After searching the mass action in the MAGE2 core file they too use the same method.
i refered the following path file is vendor/magento/module-cms/Controller/Adminhtml/Block/MassDelete.php
from line no 51 to 53
foreach ($collection as $page)
{
$page->delete();
}
i appreciate any one help on this.
magento2
magento2
asked Jun 22 '17 at 14:02
JjoJjo
835214
asked Jun 22 '17 at 14:02
JjoJjo
835214
edited Jun 29 '17 at 10:45
Jjo
asked Jun 22 '17 at 14:02
JjoJjo
835214
asked Jun 22 '17 at 14:02
JjoJjo
835214
asked Jun 22 '17 at 14:02
JjoJjo
835214
835214
bumped to the homepage by Community♦ 2 mins ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
bumped to the homepage by Community♦ 2 mins ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
instead of iterating and deleting on object, use custom My Sql query to delete multiple row with where cause.
– Minesh Patel
Jun 29 '17 at 10:48
delete on object is only useful when you want to perform other operation before deleting it.
– Minesh Patel
Jun 29 '17 at 10:51
@Jjo did you find an answer to this? Thanks
– Tom Burman
Aug 2 '17 at 6:23
add a comment |
instead of iterating and deleting on object, use custom My Sql query to delete multiple row with where cause.
– Minesh Patel
Jun 29 '17 at 10:48
delete on object is only useful when you want to perform other operation before deleting it.
– Minesh Patel
Jun 29 '17 at 10:51
@Jjo did you find an answer to this? Thanks
– Tom Burman
Aug 2 '17 at 6:23
instead of iterating and deleting on object, use custom My Sql query to delete multiple row with where cause.
– Minesh Patel
Jun 29 '17 at 10:48
instead of iterating and deleting on object, use custom My Sql query to delete multiple row with where cause.
– Minesh Patel
Jun 29 '17 at 10:48
delete on object is only useful when you want to perform other operation before deleting it.
– Minesh Patel
Jun 29 '17 at 10:51
delete on object is only useful when you want to perform other operation before deleting it.
– Minesh Patel
Jun 29 '17 at 10:51
@Jjo did you find an answer to this? Thanks
– Tom Burman
Aug 2 '17 at 6:23
@Jjo did you find an answer to this? Thanks
– Tom Burman
Aug 2 '17 at 6:23
add a comment |
1 Answer
1
active
oldest
votes
try {
$categoriesIds = ['1','2','3'];
// use collection factory object of particular model
$catgoryObj = $this->_objectManager->get('MageArrayGalleryModelResourceModelCategoryCollectionFactory');
//apply addFieldToFilter to get particular record only from that collection
$category = $catgoryObj->create()->addFieldToFilter('category_id', array('in' => $categoriesIds));
//use walk method for mass delete action
$category->walk('delete');
$this->messageManager->addSuccess(__('A total of %1 record(s) have been deleted.', count($categoriesIds)));
} catch (Exception $e) {
$this->messageManager->addError($e->getMessage());
}
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
add a comment |
Your Answer
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "479"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f180337%2fmass-delete-action-in-one-step-not-in-loop-magento-2%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
try {
$categoriesIds = ['1','2','3'];
// use collection factory object of particular model
$catgoryObj = $this->_objectManager->get('MageArrayGalleryModelResourceModelCategoryCollectionFactory');
//apply addFieldToFilter to get particular record only from that collection
$category = $catgoryObj->create()->addFieldToFilter('category_id', array('in' => $categoriesIds));
//use walk method for mass delete action
$category->walk('delete');
$this->messageManager->addSuccess(__('A total of %1 record(s) have been deleted.', count($categoriesIds)));
} catch (Exception $e) {
$this->messageManager->addError($e->getMessage());
}
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
add a comment |
try {
$categoriesIds = ['1','2','3'];
// use collection factory object of particular model
$catgoryObj = $this->_objectManager->get('MageArrayGalleryModelResourceModelCategoryCollectionFactory');
//apply addFieldToFilter to get particular record only from that collection
$category = $catgoryObj->create()->addFieldToFilter('category_id', array('in' => $categoriesIds));
//use walk method for mass delete action
$category->walk('delete');
$this->messageManager->addSuccess(__('A total of %1 record(s) have been deleted.', count($categoriesIds)));
} catch (Exception $e) {
$this->messageManager->addError($e->getMessage());
}
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
add a comment |
try {
$categoriesIds = ['1','2','3'];
// use collection factory object of particular model
$catgoryObj = $this->_objectManager->get('MageArrayGalleryModelResourceModelCategoryCollectionFactory');
//apply addFieldToFilter to get particular record only from that collection
$category = $catgoryObj->create()->addFieldToFilter('category_id', array('in' => $categoriesIds));
//use walk method for mass delete action
$category->walk('delete');
$this->messageManager->addSuccess(__('A total of %1 record(s) have been deleted.', count($categoriesIds)));
} catch (Exception $e) {
$this->messageManager->addError($e->getMessage());
}
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
try {
$categoriesIds = ['1','2','3'];
// use collection factory object of particular model
$catgoryObj = $this->_objectManager->get('MageArrayGalleryModelResourceModelCategoryCollectionFactory');
//apply addFieldToFilter to get particular record only from that collection
$category = $catgoryObj->create()->addFieldToFilter('category_id', array('in' => $categoriesIds));
//use walk method for mass delete action
$category->walk('delete');
$this->messageManager->addSuccess(__('A total of %1 record(s) have been deleted.', count($categoriesIds)));
} catch (Exception $e) {
$this->messageManager->addError($e->getMessage());
}
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
answered Apr 4 '18 at 14:07
Prashant PatelPrashant Patel
910315
910315
add a comment |
add a comment |
Thanks for contributing an answer to Magento Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f180337%2fmass-delete-action-in-one-step-not-in-loop-magento-2%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
instead of iterating and deleting on object, use custom My Sql query to delete multiple row with where cause.
– Minesh Patel
Jun 29 '17 at 10:48
delete on object is only useful when you want to perform other operation before deleting it.
– Minesh Patel
Jun 29 '17 at 10:51
@Jjo did you find an answer to this? Thanks
– Tom Burman
Aug 2 '17 at 6:23