strTok function (thread safe, supports empty tokens, doesn't change string)





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







3












$begingroup$


I'm new to C language and want to explode a string like we do in PHP explode() function, I searched for a built-in function with the C standard library, and I found strtok , but It doesn't support empty tokens like 1,2,3,,5 . Inspired by the answers I found in this SO question I made this function, it is supposed to be thread safe and support empty tokens and doesn't change the original string



char* strTok(char** newString, char* delimiter)

{

    char* string = *newString;

    char* delimiterFound = (char*) 0;

    int tokLenght = 0;

    char* tok = (char*) 0;



    if(!string) return (char*) 0;



    delimiterFound = strstr(string, delimiter);



    if(delimiterFound){

        tokLenght = delimiterFound-string;

    }else{

        tokLenght = strlen(string);

    }



    tok = malloc(tokLenght + 1);

    memcpy(tok, string, tokLenght);

    tok[tokLenght] = '';



    *newString = delimiterFound ? delimiterFound + strlen(delimiter) : (char*)0;



    return tok;

}


I designed it to be used like



char* input = "1,2,3,4,5,6,7,,,10,";

char** inputP = &input;

char* tok;

while( (tok=strTok(inputP, ",")) ){

    printf("%sn", tok);

}





beginner c strings







share|improve this question









$endgroup$








  • 1




    $begingroup$
    Better user-interface then the original strtok. You may be interested in strsep, too. code.woboq.org/userspace/glibc/string/strsep.c.html
    $endgroup$
    – Neil Edelman
    yesterday










  • $begingroup$
    @NeilEdelman thanks I never saw this function before, I will check it.
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    It's not in the standard C libraries, but in POSIX, (any type of gcc.) However, like strtok, it obliterates the char to replace it with , so it's not the same.
    $endgroup$
    – Neil Edelman
    yesterday


















3












$begingroup$


I'm new to C language and want to explode a string like we do in PHP explode() function, I searched for a built-in function with the C standard library, and I found strtok , but It doesn't support empty tokens like 1,2,3,,5 . Inspired by the answers I found in this SO question I made this function, it is supposed to be thread safe and support empty tokens and doesn't change the original string



char* strTok(char** newString, char* delimiter)

{

    char* string = *newString;

    char* delimiterFound = (char*) 0;

    int tokLenght = 0;

    char* tok = (char*) 0;



    if(!string) return (char*) 0;



    delimiterFound = strstr(string, delimiter);



    if(delimiterFound){

        tokLenght = delimiterFound-string;

    }else{

        tokLenght = strlen(string);

    }



    tok = malloc(tokLenght + 1);

    memcpy(tok, string, tokLenght);

    tok[tokLenght] = '';



    *newString = delimiterFound ? delimiterFound + strlen(delimiter) : (char*)0;



    return tok;

}


I designed it to be used like



char* input = "1,2,3,4,5,6,7,,,10,";

char** inputP = &input;

char* tok;

while( (tok=strTok(inputP, ",")) ){

    printf("%sn", tok);

}





beginner c strings







share|improve this question









$endgroup$








  • 1




    $begingroup$
    Better user-interface then the original strtok. You may be interested in strsep, too. code.woboq.org/userspace/glibc/string/strsep.c.html
    $endgroup$
    – Neil Edelman
    yesterday










  • $begingroup$
    @NeilEdelman thanks I never saw this function before, I will check it.
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    It's not in the standard C libraries, but in POSIX, (any type of gcc.) However, like strtok, it obliterates the char to replace it with , so it's not the same.
    $endgroup$
    – Neil Edelman
    yesterday














3












3








3





$begingroup$


I'm new to C language and want to explode a string like we do in PHP explode() function, I searched for a built-in function with the C standard library, and I found strtok , but It doesn't support empty tokens like 1,2,3,,5 . Inspired by the answers I found in this SO question I made this function, it is supposed to be thread safe and support empty tokens and doesn't change the original string



char* strTok(char** newString, char* delimiter)

{

    char* string = *newString;

    char* delimiterFound = (char*) 0;

    int tokLenght = 0;

    char* tok = (char*) 0;



    if(!string) return (char*) 0;



    delimiterFound = strstr(string, delimiter);



    if(delimiterFound){

        tokLenght = delimiterFound-string;

    }else{

        tokLenght = strlen(string);

    }



    tok = malloc(tokLenght + 1);

    memcpy(tok, string, tokLenght);

    tok[tokLenght] = '';



    *newString = delimiterFound ? delimiterFound + strlen(delimiter) : (char*)0;



    return tok;

}


I designed it to be used like



char* input = "1,2,3,4,5,6,7,,,10,";

char** inputP = &input;

char* tok;

while( (tok=strTok(inputP, ",")) ){

    printf("%sn", tok);

}





beginner c strings







share|improve this question









$endgroup$




I'm new to C language and want to explode a string like we do in PHP explode() function, I searched for a built-in function with the C standard library, and I found strtok , but It doesn't support empty tokens like 1,2,3,,5 . Inspired by the answers I found in this SO question I made this function, it is supposed to be thread safe and support empty tokens and doesn't change the original string



char* strTok(char** newString, char* delimiter)

{

    char* string = *newString;

    char* delimiterFound = (char*) 0;

    int tokLenght = 0;

    char* tok = (char*) 0;



    if(!string) return (char*) 0;



    delimiterFound = strstr(string, delimiter);



    if(delimiterFound){

        tokLenght = delimiterFound-string;

    }else{

        tokLenght = strlen(string);

    }



    tok = malloc(tokLenght + 1);

    memcpy(tok, string, tokLenght);

    tok[tokLenght] = '';



    *newString = delimiterFound ? delimiterFound + strlen(delimiter) : (char*)0;



    return tok;

}


I designed it to be used like



char* input = "1,2,3,4,5,6,7,,,10,";

char** inputP = &input;

char* tok;

while( (tok=strTok(inputP, ",")) ){

    printf("%sn", tok);

}





beginner c strings




beginner c strings






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked yesterday









Accountant مAccountant م

1978




1978








  • 1




    $begingroup$
    Better user-interface then the original strtok. You may be interested in strsep, too. code.woboq.org/userspace/glibc/string/strsep.c.html
    $endgroup$
    – Neil Edelman
    yesterday










  • $begingroup$
    @NeilEdelman thanks I never saw this function before, I will check it.
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    It's not in the standard C libraries, but in POSIX, (any type of gcc.) However, like strtok, it obliterates the char to replace it with , so it's not the same.
    $endgroup$
    – Neil Edelman
    yesterday














  • 1




    $begingroup$
    Better user-interface then the original strtok. You may be interested in strsep, too. code.woboq.org/userspace/glibc/string/strsep.c.html
    $endgroup$
    – Neil Edelman
    yesterday










  • $begingroup$
    @NeilEdelman thanks I never saw this function before, I will check it.
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    It's not in the standard C libraries, but in POSIX, (any type of gcc.) However, like strtok, it obliterates the char to replace it with , so it's not the same.
    $endgroup$
    – Neil Edelman
    yesterday








1




1




$begingroup$
Better user-interface then the original strtok. You may be interested in strsep, too. code.woboq.org/userspace/glibc/string/strsep.c.html
$endgroup$
– Neil Edelman
yesterday




$begingroup$
Better user-interface then the original strtok. You may be interested in strsep, too. code.woboq.org/userspace/glibc/string/strsep.c.html
$endgroup$
– Neil Edelman
yesterday












$begingroup$
@NeilEdelman thanks I never saw this function before, I will check it.
$endgroup$
– Accountant م
yesterday




$begingroup$
@NeilEdelman thanks I never saw this function before, I will check it.
$endgroup$
– Accountant م
yesterday




1




1




$begingroup$
It's not in the standard C libraries, but in POSIX, (any type of gcc.) However, like strtok, it obliterates the char to replace it with , so it's not the same.
$endgroup$
– Neil Edelman
yesterday




$begingroup$
It's not in the standard C libraries, but in POSIX, (any type of gcc.) However, like strtok, it obliterates the char to replace it with , so it's not the same.
$endgroup$
– Neil Edelman
yesterday










2 Answers
2






active

oldest

votes


















3












$begingroup$


  • delimiterFound + strlen(delimiter) sounds like a bug. If the delimiter is longer than one character, *newString will point too far into the original, maybe even beyond the end. Correct me if I am wrong, delimiterFound + 1 is what you are actually after.



  • Modern C allows, and strongly encourages, to declare variables as close to their use a possible. Consider



    char * delimiterFound = strstr(string, delimiter);
    
....
    
char * tok = malloc(tokLenght + 1);


    etc.



  • Always test that malloc didn't fail.



  • More spaces - around keywords, braces, etc - definitely improve readability:



        if (....) {
    
        ....
    
    } else {
    
        ....
    
    }







share|improve this answer









$endgroup$









  • 1




    $begingroup$
    Thaaank you very much for these precious points, regarding the delimiter length bug, ummmm, I want to support long delimiters more than 1 characters like the boundary string in http requests that has content-type multi-part, and I don't think it's a bug because delimiterFound + strlen(delimiter) can never be after the 0 byte that terminates the original string!, right ? "fooDELIMITER" 3 + 12
    $endgroup$
    – Accountant م
    yesterday










  • $begingroup$
    @Accountantم Long delimiters here refer to, say ",;.", in where any character delimits the string on its own right.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    I didn't get it, I'm sorry, can you please give me an example input that can break this code, exploiting this bug ?
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    @Accountantم Sorry for not being clear. I should realize that your intentions are different (and read man strstr more carefully). Consider it my blinder - since you mentioned strtok, I expected the strtok semantics.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    It's my fault because I said it's strtok, I wanted strtok that can support delimiters more than 1 characters, because I need this feature a lot. So do you mean it's not a bug ??
    $endgroup$
    – Accountant م
    yesterday



















2












$begingroup$

From a readability viewpoint, you should use NULL instead of (char*) 0 as it is easier to recognize what you're trying to do. Also, the tokLenght misspells "length", and should probably be tokLength.



You leak memory, as the memory allocated to hold the returned string is never freed.






share|improve this answer









$endgroup$













  • $begingroup$
    Thank you very much I will use NULL from now on, and I will remember to free() memory , 'I miss PHP garbage collector :(', I didn't get the tokLength spelling note, aren't they the same ?
    $endgroup$
    – Accountant م
    yesterday








  • 1




    $begingroup$
    It's a matter of style, and including .h if you want to use NULL. However, you don't have to cast (char *)0, just use 0 (or NULL.) It knows from the return type.
    $endgroup$
    – Neil Edelman
    yesterday






  • 1




    $begingroup$
    @Accountantم For the spelling, you used G-H-T when the correct spelling is G-T-H (the last two letters are swapped). I've made that typo before. I find having identifiers spelled correctly helps with reading and finding them, although the autocomplete in IDEs mitigates that a little but propagates the misspellings.
    $endgroup$
    – 1201ProgramAlarm
    13 hours ago










  • $begingroup$
    @1201ProgramAlarm ooh, 😮 how come I didn't notice this after revising it multiple times!, thanks.
    $endgroup$
    – Accountant م
    12 hours ago












Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216956%2fstrtok-function-thread-safe-supports-empty-tokens-doesnt-change-string%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























2 Answers
2






active

oldest

votes








2 Answers
2






active

oldest

votes









active

oldest

votes






active

oldest

votes









3












$begingroup$


  • delimiterFound + strlen(delimiter) sounds like a bug. If the delimiter is longer than one character, *newString will point too far into the original, maybe even beyond the end. Correct me if I am wrong, delimiterFound + 1 is what you are actually after.



  • Modern C allows, and strongly encourages, to declare variables as close to their use a possible. Consider



    char * delimiterFound = strstr(string, delimiter);
    
....
    
char * tok = malloc(tokLenght + 1);


    etc.



  • Always test that malloc didn't fail.



  • More spaces - around keywords, braces, etc - definitely improve readability:



        if (....) {
    
        ....
    
    } else {
    
        ....
    
    }







share|improve this answer









$endgroup$









  • 1




    $begingroup$
    Thaaank you very much for these precious points, regarding the delimiter length bug, ummmm, I want to support long delimiters more than 1 characters like the boundary string in http requests that has content-type multi-part, and I don't think it's a bug because delimiterFound + strlen(delimiter) can never be after the 0 byte that terminates the original string!, right ? "fooDELIMITER" 3 + 12
    $endgroup$
    – Accountant م
    yesterday










  • $begingroup$
    @Accountantم Long delimiters here refer to, say ",;.", in where any character delimits the string on its own right.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    I didn't get it, I'm sorry, can you please give me an example input that can break this code, exploiting this bug ?
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    @Accountantم Sorry for not being clear. I should realize that your intentions are different (and read man strstr more carefully). Consider it my blinder - since you mentioned strtok, I expected the strtok semantics.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    It's my fault because I said it's strtok, I wanted strtok that can support delimiters more than 1 characters, because I need this feature a lot. So do you mean it's not a bug ??
    $endgroup$
    – Accountant م
    yesterday
















3












$begingroup$


  • delimiterFound + strlen(delimiter) sounds like a bug. If the delimiter is longer than one character, *newString will point too far into the original, maybe even beyond the end. Correct me if I am wrong, delimiterFound + 1 is what you are actually after.



  • Modern C allows, and strongly encourages, to declare variables as close to their use a possible. Consider



    char * delimiterFound = strstr(string, delimiter);
    
....
    
char * tok = malloc(tokLenght + 1);


    etc.



  • Always test that malloc didn't fail.



  • More spaces - around keywords, braces, etc - definitely improve readability:



        if (....) {
    
        ....
    
    } else {
    
        ....
    
    }







share|improve this answer









$endgroup$









  • 1




    $begingroup$
    Thaaank you very much for these precious points, regarding the delimiter length bug, ummmm, I want to support long delimiters more than 1 characters like the boundary string in http requests that has content-type multi-part, and I don't think it's a bug because delimiterFound + strlen(delimiter) can never be after the 0 byte that terminates the original string!, right ? "fooDELIMITER" 3 + 12
    $endgroup$
    – Accountant م
    yesterday










  • $begingroup$
    @Accountantم Long delimiters here refer to, say ",;.", in where any character delimits the string on its own right.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    I didn't get it, I'm sorry, can you please give me an example input that can break this code, exploiting this bug ?
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    @Accountantم Sorry for not being clear. I should realize that your intentions are different (and read man strstr more carefully). Consider it my blinder - since you mentioned strtok, I expected the strtok semantics.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    It's my fault because I said it's strtok, I wanted strtok that can support delimiters more than 1 characters, because I need this feature a lot. So do you mean it's not a bug ??
    $endgroup$
    – Accountant م
    yesterday














3












3








3





$begingroup$


  • delimiterFound + strlen(delimiter) sounds like a bug. If the delimiter is longer than one character, *newString will point too far into the original, maybe even beyond the end. Correct me if I am wrong, delimiterFound + 1 is what you are actually after.



  • Modern C allows, and strongly encourages, to declare variables as close to their use a possible. Consider



    char * delimiterFound = strstr(string, delimiter);
    
....
    
char * tok = malloc(tokLenght + 1);


    etc.



  • Always test that malloc didn't fail.



  • More spaces - around keywords, braces, etc - definitely improve readability:



        if (....) {
    
        ....
    
    } else {
    
        ....
    
    }







share|improve this answer









$endgroup$




  • delimiterFound + strlen(delimiter) sounds like a bug. If the delimiter is longer than one character, *newString will point too far into the original, maybe even beyond the end. Correct me if I am wrong, delimiterFound + 1 is what you are actually after.



  • Modern C allows, and strongly encourages, to declare variables as close to their use a possible. Consider



    char * delimiterFound = strstr(string, delimiter);
    
....
    
char * tok = malloc(tokLenght + 1);


    etc.



  • Always test that malloc didn't fail.



  • More spaces - around keywords, braces, etc - definitely improve readability:



        if (....) {
    
        ....
    
    } else {
    
        ....
    
    }








share|improve this answer












share|improve this answer



share|improve this answer










answered yesterday









vnpvnp

40.6k233103




40.6k233103








  • 1




    $begingroup$
    Thaaank you very much for these precious points, regarding the delimiter length bug, ummmm, I want to support long delimiters more than 1 characters like the boundary string in http requests that has content-type multi-part, and I don't think it's a bug because delimiterFound + strlen(delimiter) can never be after the 0 byte that terminates the original string!, right ? "fooDELIMITER" 3 + 12
    $endgroup$
    – Accountant م
    yesterday










  • $begingroup$
    @Accountantم Long delimiters here refer to, say ",;.", in where any character delimits the string on its own right.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    I didn't get it, I'm sorry, can you please give me an example input that can break this code, exploiting this bug ?
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    @Accountantم Sorry for not being clear. I should realize that your intentions are different (and read man strstr more carefully). Consider it my blinder - since you mentioned strtok, I expected the strtok semantics.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    It's my fault because I said it's strtok, I wanted strtok that can support delimiters more than 1 characters, because I need this feature a lot. So do you mean it's not a bug ??
    $endgroup$
    – Accountant م
    yesterday














  • 1




    $begingroup$
    Thaaank you very much for these precious points, regarding the delimiter length bug, ummmm, I want to support long delimiters more than 1 characters like the boundary string in http requests that has content-type multi-part, and I don't think it's a bug because delimiterFound + strlen(delimiter) can never be after the 0 byte that terminates the original string!, right ? "fooDELIMITER" 3 + 12
    $endgroup$
    – Accountant م
    yesterday










  • $begingroup$
    @Accountantم Long delimiters here refer to, say ",;.", in where any character delimits the string on its own right.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    I didn't get it, I'm sorry, can you please give me an example input that can break this code, exploiting this bug ?
    $endgroup$
    – Accountant م
    yesterday






  • 1




    $begingroup$
    @Accountantم Sorry for not being clear. I should realize that your intentions are different (and read man strstr more carefully). Consider it my blinder - since you mentioned strtok, I expected the strtok semantics.
    $endgroup$
    – vnp
    yesterday










  • $begingroup$
    It's my fault because I said it's strtok, I wanted strtok that can support delimiters more than 1 characters, because I need this feature a lot. So do you mean it's not a bug ??
    $endgroup$
    – Accountant م
    yesterday








1




1




$begingroup$
Thaaank you very much for these precious points, regarding the delimiter length bug, ummmm, I want to support long delimiters more than 1 characters like the boundary string in http requests that has content-type multi-part, and I don't think it's a bug because delimiterFound + strlen(delimiter) can never be after the 0 byte that terminates the original string!, right ? "fooDELIMITER" 3 + 12
$endgroup$
– Accountant م
yesterday




$begingroup$
Thaaank you very much for these precious points, regarding the delimiter length bug, ummmm, I want to support long delimiters more than 1 characters like the boundary string in http requests that has content-type multi-part, and I don't think it's a bug because delimiterFound + strlen(delimiter) can never be after the 0 byte that terminates the original string!, right ? "fooDELIMITER" 3 + 12
$endgroup$
– Accountant م
yesterday












$begingroup$
@Accountantم Long delimiters here refer to, say ",;.", in where any character delimits the string on its own right.
$endgroup$
– vnp
yesterday




$begingroup$
@Accountantم Long delimiters here refer to, say ",;.", in where any character delimits the string on its own right.
$endgroup$
– vnp
yesterday












$begingroup$
I didn't get it, I'm sorry, can you please give me an example input that can break this code, exploiting this bug ?
$endgroup$
– Accountant م
yesterday




$begingroup$
I didn't get it, I'm sorry, can you please give me an example input that can break this code, exploiting this bug ?
$endgroup$
– Accountant م
yesterday




1




1




$begingroup$
@Accountantم Sorry for not being clear. I should realize that your intentions are different (and read man strstr more carefully). Consider it my blinder - since you mentioned strtok, I expected the strtok semantics.
$endgroup$
– vnp
yesterday




$begingroup$
@Accountantم Sorry for not being clear. I should realize that your intentions are different (and read man strstr more carefully). Consider it my blinder - since you mentioned strtok, I expected the strtok semantics.
$endgroup$
– vnp
yesterday












$begingroup$
It's my fault because I said it's strtok, I wanted strtok that can support delimiters more than 1 characters, because I need this feature a lot. So do you mean it's not a bug ??
$endgroup$
– Accountant م
yesterday




$begingroup$
It's my fault because I said it's strtok, I wanted strtok that can support delimiters more than 1 characters, because I need this feature a lot. So do you mean it's not a bug ??
$endgroup$
– Accountant م
yesterday













2












$begingroup$

From a readability viewpoint, you should use NULL instead of (char*) 0 as it is easier to recognize what you're trying to do. Also, the tokLenght misspells "length", and should probably be tokLength.



You leak memory, as the memory allocated to hold the returned string is never freed.






share|improve this answer









$endgroup$













  • $begingroup$
    Thank you very much I will use NULL from now on, and I will remember to free() memory , 'I miss PHP garbage collector :(', I didn't get the tokLength spelling note, aren't they the same ?
    $endgroup$
    – Accountant م
    yesterday








  • 1




    $begingroup$
    It's a matter of style, and including .h if you want to use NULL. However, you don't have to cast (char *)0, just use 0 (or NULL.) It knows from the return type.
    $endgroup$
    – Neil Edelman
    yesterday






  • 1




    $begingroup$
    @Accountantم For the spelling, you used G-H-T when the correct spelling is G-T-H (the last two letters are swapped). I've made that typo before. I find having identifiers spelled correctly helps with reading and finding them, although the autocomplete in IDEs mitigates that a little but propagates the misspellings.
    $endgroup$
    – 1201ProgramAlarm
    13 hours ago










  • $begingroup$
    @1201ProgramAlarm ooh, 😮 how come I didn't notice this after revising it multiple times!, thanks.
    $endgroup$
    – Accountant م
    12 hours ago
















2












$begingroup$

From a readability viewpoint, you should use NULL instead of (char*) 0 as it is easier to recognize what you're trying to do. Also, the tokLenght misspells "length", and should probably be tokLength.



You leak memory, as the memory allocated to hold the returned string is never freed.






share|improve this answer









$endgroup$













  • $begingroup$
    Thank you very much I will use NULL from now on, and I will remember to free() memory , 'I miss PHP garbage collector :(', I didn't get the tokLength spelling note, aren't they the same ?
    $endgroup$
    – Accountant م
    yesterday








  • 1




    $begingroup$
    It's a matter of style, and including .h if you want to use NULL. However, you don't have to cast (char *)0, just use 0 (or NULL.) It knows from the return type.
    $endgroup$
    – Neil Edelman
    yesterday






  • 1




    $begingroup$
    @Accountantم For the spelling, you used G-H-T when the correct spelling is G-T-H (the last two letters are swapped). I've made that typo before. I find having identifiers spelled correctly helps with reading and finding them, although the autocomplete in IDEs mitigates that a little but propagates the misspellings.
    $endgroup$
    – 1201ProgramAlarm
    13 hours ago










  • $begingroup$
    @1201ProgramAlarm ooh, 😮 how come I didn't notice this after revising it multiple times!, thanks.
    $endgroup$
    – Accountant م
    12 hours ago














2












2








2





$begingroup$

From a readability viewpoint, you should use NULL instead of (char*) 0 as it is easier to recognize what you're trying to do. Also, the tokLenght misspells "length", and should probably be tokLength.



You leak memory, as the memory allocated to hold the returned string is never freed.






share|improve this answer









$endgroup$



From a readability viewpoint, you should use NULL instead of (char*) 0 as it is easier to recognize what you're trying to do. Also, the tokLenght misspells "length", and should probably be tokLength.



You leak memory, as the memory allocated to hold the returned string is never freed.







share|improve this answer












share|improve this answer



share|improve this answer










answered yesterday









1201ProgramAlarm1201ProgramAlarm

3,6832925




3,6832925












  • $begingroup$
    Thank you very much I will use NULL from now on, and I will remember to free() memory , 'I miss PHP garbage collector :(', I didn't get the tokLength spelling note, aren't they the same ?
    $endgroup$
    – Accountant م
    yesterday








  • 1




    $begingroup$
    It's a matter of style, and including .h if you want to use NULL. However, you don't have to cast (char *)0, just use 0 (or NULL.) It knows from the return type.
    $endgroup$
    – Neil Edelman
    yesterday






  • 1




    $begingroup$
    @Accountantم For the spelling, you used G-H-T when the correct spelling is G-T-H (the last two letters are swapped). I've made that typo before. I find having identifiers spelled correctly helps with reading and finding them, although the autocomplete in IDEs mitigates that a little but propagates the misspellings.
    $endgroup$
    – 1201ProgramAlarm
    13 hours ago










  • $begingroup$
    @1201ProgramAlarm ooh, 😮 how come I didn't notice this after revising it multiple times!, thanks.
    $endgroup$
    – Accountant م
    12 hours ago


















  • $begingroup$
    Thank you very much I will use NULL from now on, and I will remember to free() memory , 'I miss PHP garbage collector :(', I didn't get the tokLength spelling note, aren't they the same ?
    $endgroup$
    – Accountant م
    yesterday








  • 1




    $begingroup$
    It's a matter of style, and including .h if you want to use NULL. However, you don't have to cast (char *)0, just use 0 (or NULL.) It knows from the return type.
    $endgroup$
    – Neil Edelman
    yesterday






  • 1




    $begingroup$
    @Accountantم For the spelling, you used G-H-T when the correct spelling is G-T-H (the last two letters are swapped). I've made that typo before. I find having identifiers spelled correctly helps with reading and finding them, although the autocomplete in IDEs mitigates that a little but propagates the misspellings.
    $endgroup$
    – 1201ProgramAlarm
    13 hours ago










  • $begingroup$
    @1201ProgramAlarm ooh, 😮 how come I didn't notice this after revising it multiple times!, thanks.
    $endgroup$
    – Accountant م
    12 hours ago
















$begingroup$
Thank you very much I will use NULL from now on, and I will remember to free() memory , 'I miss PHP garbage collector :(', I didn't get the tokLength spelling note, aren't they the same ?
$endgroup$
– Accountant م
yesterday






$begingroup$
Thank you very much I will use NULL from now on, and I will remember to free() memory , 'I miss PHP garbage collector :(', I didn't get the tokLength spelling note, aren't they the same ?
$endgroup$
– Accountant م
yesterday






1




1




$begingroup$
It's a matter of style, and including .h if you want to use NULL. However, you don't have to cast (char *)0, just use 0 (or NULL.) It knows from the return type.
$endgroup$
– Neil Edelman
yesterday




$begingroup$
It's a matter of style, and including .h if you want to use NULL. However, you don't have to cast (char *)0, just use 0 (or NULL.) It knows from the return type.
$endgroup$
– Neil Edelman
yesterday




1




1




$begingroup$
@Accountantم For the spelling, you used G-H-T when the correct spelling is G-T-H (the last two letters are swapped). I've made that typo before. I find having identifiers spelled correctly helps with reading and finding them, although the autocomplete in IDEs mitigates that a little but propagates the misspellings.
$endgroup$
– 1201ProgramAlarm
13 hours ago




$begingroup$
@Accountantم For the spelling, you used G-H-T when the correct spelling is G-T-H (the last two letters are swapped). I've made that typo before. I find having identifiers spelled correctly helps with reading and finding them, although the autocomplete in IDEs mitigates that a little but propagates the misspellings.
$endgroup$
– 1201ProgramAlarm
13 hours ago












$begingroup$
@1201ProgramAlarm ooh, 😮 how come I didn't notice this after revising it multiple times!, thanks.
$endgroup$
– Accountant م
12 hours ago




$begingroup$
@1201ProgramAlarm ooh, 😮 how come I didn't notice this after revising it multiple times!, thanks.
$endgroup$
– Accountant م
12 hours ago


















draft saved

draft discarded




















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid …



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216956%2fstrtok-function-thread-safe-supports-empty-tokens-doesnt-change-string%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







-

Popular posts from this blog

What other Star Trek series did the main TNG cast show up in?

Image
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0; } 4 I'm referring to Picard, Riker, Data, Worf, Geordi, Dr. Crusher, Wesley Crusher, Chief O'Brien and family, Deanna Troi, Guinan. I know Picard and Worf show up on DS9, though I haven't seen it myself. I'm curious what happened to the characters after that last episode of TNG? star-trek star-trek-tng share | improve this question edited 10 hours ago Ham Sandwich 6,051 2 25 75 ...
Read more

Berlina muro

Image
La berlina muro ĉe Bethaniendamm, 1986 La berlina muro aŭ simple la muro [1] , nomita ankaŭ "kontraŭfaŝisma remparo" en propaganda lingvo de la iama Germana Demokratia Respubliko, estis parto de la interngermana limo, kiu dividis de la 13-a de aŭgusto 1961 ĝis la 9-a de novembro 1989 okcidentan Berlinon de la orienta parto de la urbo kaj de la ĉirkaŭa tereno de la GDR. Ĝi estis unu el la plej famaj simboloj de la malvarma milito kaj de la disdivido de Germanio. Pli ol simpla muro, la berlina muro estis fakte tuta defendokonstruaĵo kun du muroj, ena malplena strio, rondirvojo, gardturoj kaj alarmsistemoj. Dum la provo transiri la severe garditan limon al okcidenta Berlino multaj homoj estis mortigitaj. La preciza nombro de viktimoj estas pridisputita kaj ne certa; la nombroj anoncataj varias inter 86 kaj 238 mortintoj. La malplifortiĝo de Sovetunio kaj la politiko de liberigo gvidita de Miĥail Gorbaĉov ebligis al la orientgermanoj faligi la 9-an de novembro 1989 l...
Read more

Berlina aerponto

Image
Flugkoridoroj dum la blokado de Berlino La Berlina aerponto estas la provizigo de okcidenta Berlino per aviadiloj fare de la aliancanoj inter la 23-a de junio 1948 kaj la 12-a de majo 1949 dum la blokado de Berlino fare de la sovetia armeo. Enhavo 1 Historio 1.1 La aerkoridoroj 1.2 Unuaj flugoj 1.3 Plibonigo de la aerponto 1.4 Fino de la aerponto 1.5 Rozinbombiloj 1.6 Bilanco 2 Flughavenoj 2.1 Berlino 2.2 Okcidenta Germanio 3 Aviadiloj de la berlina aerponto 4 15-a datreveno de la aerponto 5 Bibliografio 6 Referencoj 7 Eksteraj ligiloj Historio | General Lucius D. Clay, militguberniestro de la usona okupadzono Jam antaŭ la berlina aerponto estiĝis la malgranda aerponto . La estro de la sovetia militadministracio en Germanio, Vasili Daniloviĉ Sokolovski, ordonis la 1-an de aprilo 1948, kiel reago al la konferenco de Londono inter britoj, francoj kaj reprezentantoj de Benelukso pri aligo de Germa...
Read more