Resolved - Mass Action - Mass Database Update in Magento Grid












0















I have this grid developed for the custom module. I added the mass delete action which works fine. But the mass Approve/Disapprove actions work only for one value, when I select multiple values I get this error.
Please help to resolve this:



enter image description here



Here is the code for the approve function in controller file:



    public function massApproveAction() {
$requestIds = $this->getRequest()->getParam('id');
if(!is_array($requestIds)) {
Mage::getSingleton('adminhtml/session')->addError(Mage::helper('adminhtml')->__('Please select reqeust(s)'));
} else {
try {

foreach ($requestIds as $requestId) {
$RequestData = Mage::getModel('cpstest_productcomment/cps')->load($requestId);
$id = $this->getRequest()->getParam('id');
$data = array('comment_status'=>'Approved');
$model = Mage::getModel('cpstest_productcomment/cps')->addData($data);
}
$model->setId($id)->save();
echo "Data updated successfully.";

} catch (Exception $e){
echo $e->getMessage();
}
}
}









share|improve this question





























    0















    I have this grid developed for the custom module. I added the mass delete action which works fine. But the mass Approve/Disapprove actions work only for one value, when I select multiple values I get this error.
    Please help to resolve this:



    enter image description here



    Here is the code for the approve function in controller file:



        public function massApproveAction() {
    $requestIds = $this->getRequest()->getParam('id');
    if(!is_array($requestIds)) {
    Mage::getSingleton('adminhtml/session')->addError(Mage::helper('adminhtml')->__('Please select reqeust(s)'));
    } else {
    try {

    foreach ($requestIds as $requestId) {
    $RequestData = Mage::getModel('cpstest_productcomment/cps')->load($requestId);
    $id = $this->getRequest()->getParam('id');
    $data = array('comment_status'=>'Approved');
    $model = Mage::getModel('cpstest_productcomment/cps')->addData($data);
    }
    $model->setId($id)->save();
    echo "Data updated successfully.";

    } catch (Exception $e){
    echo $e->getMessage();
    }
    }
    }









    share|improve this question



























      0












      0








      0








      I have this grid developed for the custom module. I added the mass delete action which works fine. But the mass Approve/Disapprove actions work only for one value, when I select multiple values I get this error.
      Please help to resolve this:



      enter image description here



      Here is the code for the approve function in controller file:



          public function massApproveAction() {
      $requestIds = $this->getRequest()->getParam('id');
      if(!is_array($requestIds)) {
      Mage::getSingleton('adminhtml/session')->addError(Mage::helper('adminhtml')->__('Please select reqeust(s)'));
      } else {
      try {

      foreach ($requestIds as $requestId) {
      $RequestData = Mage::getModel('cpstest_productcomment/cps')->load($requestId);
      $id = $this->getRequest()->getParam('id');
      $data = array('comment_status'=>'Approved');
      $model = Mage::getModel('cpstest_productcomment/cps')->addData($data);
      }
      $model->setId($id)->save();
      echo "Data updated successfully.";

      } catch (Exception $e){
      echo $e->getMessage();
      }
      }
      }









      share|improve this question
















      I have this grid developed for the custom module. I added the mass delete action which works fine. But the mass Approve/Disapprove actions work only for one value, when I select multiple values I get this error.
      Please help to resolve this:



      enter image description here



      Here is the code for the approve function in controller file:



          public function massApproveAction() {
      $requestIds = $this->getRequest()->getParam('id');
      if(!is_array($requestIds)) {
      Mage::getSingleton('adminhtml/session')->addError(Mage::helper('adminhtml')->__('Please select reqeust(s)'));
      } else {
      try {

      foreach ($requestIds as $requestId) {
      $RequestData = Mage::getModel('cpstest_productcomment/cps')->load($requestId);
      $id = $this->getRequest()->getParam('id');
      $data = array('comment_status'=>'Approved');
      $model = Mage::getModel('cpstest_productcomment/cps')->addData($data);
      }
      $model->setId($id)->save();
      echo "Data updated successfully.";

      } catch (Exception $e){
      echo $e->getMessage();
      }
      }
      }






      magento-1.9 module grid custom massaction






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Apr 6 '17 at 18:22







      bestwebdevs

















      asked Apr 6 '17 at 0:24









      bestwebdevsbestwebdevs

      122213




      122213






















          1 Answer
          1






          active

          oldest

          votes


















          1














          Everything is correct but at the time of saving data you set all request params in setId method. Please find below line and correct it.



          $model->setId($id)->save();


          Replace with below code



          $model->setId($requestId)->save();





          share|improve this answer


























          • Thanks for your respond. With this code I don't get the error any more, but it still saves only one value.

            – bestwebdevs
            Apr 6 '17 at 16:58













          • Your solution is correct, I made a mistake and put it outside the loop, that's why it was only saving 1 value. Then I put it in the foreach loop and it works great :) Thank you!

            – bestwebdevs
            Apr 6 '17 at 17:34












          Your Answer








          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "479"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f167880%2fresolved-mass-action-mass-database-update-in-magento-grid%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          1














          Everything is correct but at the time of saving data you set all request params in setId method. Please find below line and correct it.



          $model->setId($id)->save();


          Replace with below code



          $model->setId($requestId)->save();





          share|improve this answer


























          • Thanks for your respond. With this code I don't get the error any more, but it still saves only one value.

            – bestwebdevs
            Apr 6 '17 at 16:58













          • Your solution is correct, I made a mistake and put it outside the loop, that's why it was only saving 1 value. Then I put it in the foreach loop and it works great :) Thank you!

            – bestwebdevs
            Apr 6 '17 at 17:34
















          1














          Everything is correct but at the time of saving data you set all request params in setId method. Please find below line and correct it.



          $model->setId($id)->save();


          Replace with below code



          $model->setId($requestId)->save();





          share|improve this answer


























          • Thanks for your respond. With this code I don't get the error any more, but it still saves only one value.

            – bestwebdevs
            Apr 6 '17 at 16:58













          • Your solution is correct, I made a mistake and put it outside the loop, that's why it was only saving 1 value. Then I put it in the foreach loop and it works great :) Thank you!

            – bestwebdevs
            Apr 6 '17 at 17:34














          1












          1








          1







          Everything is correct but at the time of saving data you set all request params in setId method. Please find below line and correct it.



          $model->setId($id)->save();


          Replace with below code



          $model->setId($requestId)->save();





          share|improve this answer















          Everything is correct but at the time of saving data you set all request params in setId method. Please find below line and correct it.



          $model->setId($id)->save();


          Replace with below code



          $model->setId($requestId)->save();






          share|improve this answer














          share|improve this answer



          share|improve this answer








          edited 7 mins ago









          Teja Bhagavan Kollepara

          3,01241949




          3,01241949










          answered Apr 6 '17 at 6:25









          ARVIND KARKARARVIND KARKAR

          4722418




          4722418













          • Thanks for your respond. With this code I don't get the error any more, but it still saves only one value.

            – bestwebdevs
            Apr 6 '17 at 16:58













          • Your solution is correct, I made a mistake and put it outside the loop, that's why it was only saving 1 value. Then I put it in the foreach loop and it works great :) Thank you!

            – bestwebdevs
            Apr 6 '17 at 17:34



















          • Thanks for your respond. With this code I don't get the error any more, but it still saves only one value.

            – bestwebdevs
            Apr 6 '17 at 16:58













          • Your solution is correct, I made a mistake and put it outside the loop, that's why it was only saving 1 value. Then I put it in the foreach loop and it works great :) Thank you!

            – bestwebdevs
            Apr 6 '17 at 17:34

















          Thanks for your respond. With this code I don't get the error any more, but it still saves only one value.

          – bestwebdevs
          Apr 6 '17 at 16:58







          Thanks for your respond. With this code I don't get the error any more, but it still saves only one value.

          – bestwebdevs
          Apr 6 '17 at 16:58















          Your solution is correct, I made a mistake and put it outside the loop, that's why it was only saving 1 value. Then I put it in the foreach loop and it works great :) Thank you!

          – bestwebdevs
          Apr 6 '17 at 17:34





          Your solution is correct, I made a mistake and put it outside the loop, that's why it was only saving 1 value. Then I put it in the foreach loop and it works great :) Thank you!

          – bestwebdevs
          Apr 6 '17 at 17:34


















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Magento Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f167880%2fresolved-mass-action-mass-database-update-in-magento-grid%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          What other Star Trek series did the main TNG cast show up in?

          Berlina muro

          Berlina aerponto